Mercurial > pymonkey

changeset 4:2711b636f8e6

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Added support for NULL return values.
author Atul Varma <varmaa@toolness.com>
date Sun, 28 Jun 2009 12:43:02 -0700
parents d6a0819ca6ca
children aae78eac86d6
files pymonkey.c test_pymonkey.py
diffstat 2 files changed, 10 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/pymonkey.c	Sun Jun 28 12:38:36 2009 -0700
+++ b/pymonkey.c	Sun Jun 28 12:43:02 2009 -0700
@@ -20,10 +20,14 @@
     return PyFloat_FromDouble(*doubleRef);
   }
 
-  // TODO: Support more types.
+  if (JSVAL_IS_NULL(value)) {
+    Py_INCREF(Py_None);
+    return Py_None;
+  }
 
-  Py_INCREF(Py_None);
-  return Py_None;
+  // TODO: Support more types.
+  PyErr_SetString(PyExc_NotImplementedError,
+                  "Data type conversion not implemented.");
 }
 
 static PyObject *
--- a/test_pymonkey.py	Sun Jun 28 12:38:36 2009 -0700
+++ b/test_pymonkey.py	Sun Jun 28 12:43:02 2009 -0700
@@ -2,6 +2,9 @@
 import pymonkey
 
 class PymonkeyTests(unittest.TestCase):
+    def testEvaluateReturnsNone(self):
+        self.assertTrue(pymonkey.evaluate('null', '<string>', 1) is None)
+
     def testEvaluateReturnsIntegers(self):
         self.assertEqual(pymonkey.evaluate('1+3', '<string>', 1),
                          4)