snowl: modules/service.js comparison

comparison modules/service.js @ 357:1db123f46ed7

add some glue to let sources be queried to see if they are also targets

author	Myk Melez <myk@mozilla.org>
date	Mon, 03 Nov 2008 18:02:27 -0800
parents	e9d7087abad1
children	c00b3db58dcf

comparison

equal deleted inserted replaced

-:8d90feea857c
+:1db123f46ed7
 const Cc = Components.classes;
 const Ci = Components.interfaces;
 const Cr = Components.results;
 const Cu = Components.utils;
+// modules that come with Firefox
 Cu.import("resource://gre/modules/XPCOMUtils.jsm");
+// modules that are generic
 Cu.import("resource://snowl/modules/log4moz.js");
+Cu.import("resource://snowl/modules/URI.js");
+// modules that are Snowl-specific
 Cu.import("resource://snowl/modules/datastore.js");
 Cu.import("resource://snowl/modules/feed.js");
 Cu.import("resource://snowl/modules/twitter.js");
 Cu.import("resource://snowl/modules/source.js");
-Cu.import("resource://snowl/modules/URI.js");
+Cu.import("resource://snowl/modules/target.js");
 Cu.import("resource://snowl/modules/utils.js");
 const PERMS_FILE      = 0644;
 const PERMS_DIRECTORY = 0755;
 this._prefSvc.savePrefFile(null);
 }
 }
 },
-get _getSourcesStatement() {
+get _getAccountsStatement() {
-let statement = SnowlDatastore.createStatement(
+delete this._getAccountsStatement;
+return this._getAccountsStatement = SnowlDatastore.createStatement(
 "SELECT id, type, name, machineURI, humanURI, lastRefreshed, importance FROM sources"
 );
-delete this._getSourcesStatement;
+},
-this._getSourcesStatement = statement;
-return this._getSourcesStatement;
+get accounts() {
-},
+let accounts = [];
-getSources: function() {
-let sources = [];
 try {
-while (this._getSourcesStatement.step()) {
+while (this._getAccountsStatement.step()) {
-let row = this._getSourcesStatement.row;
+let row = this._getAccountsStatement.row;
-let constructor = SnowlSource;
+let type;
 try {
-constructor = eval(row.type);
+type = eval(row.type);
+this._log.info("got " + row.type + " for " + row.name);
 }
 catch(ex) {
-this._log.warn("error evaling " + row.type + ": " + ex +
+this._log.error("error getting " + row.name + ": " + ex);
-"; falling back to SnowlSource");
+continue;
 }
-sources.push(new constructor(row.id,
+accounts.push(new type(row.id,
 row.name,
 URI.get(row.machineURI),
 URI.get(row.humanURI),
 SnowlDateUtils.julianToJSDate(row.lastRefreshed),
 row.importance));
 }
 }
 finally {
-this._getSourcesStatement.reset();
+this._getAccountsStatement.reset();
 }
-return sources;
+return accounts;
+},
+get sources() {
+return this.accounts.filter(function(acct) acct.implements(SnowlSource));
+},
+get targets() {
+return this.accounts.filter(function(acct) acct.implements(SnowlTarget));
 },
 refreshStaleSources: function() {
 this._log.info("refreshing stale sources");
-// XXX Should SnowlDatastore::selectSources return SnowlSource objects,
-// of which SnowlFeed is a subclass?  Or perhaps selectSources should simply
-// return a database cursor, and SnowlService::getSources should return
-// SnowlSource objects?
-let allSources = this.getSources();
 let now = new Date();
 let staleSources = [];
-for each (let source in allSources) {
+for each (let source in this.sources)
-//this._log.info(source.name + " last refreshed " + source.lastRefreshed + ", " + (now - source.lastRefreshed)/1000 + "s ago; interval is " + source.refreshInterval/1000 + "s");
+if (now - source.lastRefreshed > source.refreshInterval)
-if (now - source.lastRefreshed > source.refreshInterval) {
-this._log.info("source: " + source.id + " is stale; refreshing");
 staleSources.push(source);
-}
-}
 this._refreshSources(staleSources);
 },
 refreshAllSources: function() {
-let sources = this.getSources();
+this._log.info("refreshing all sources");
-this._refreshSources(sources);
+this._refreshSources(this.sources);
 },
-_refreshSources: function(aSources) {
+_refreshSources: function(sources) {
-for each (let source in aSources) {
+for each (let source in sources) {
+this._log.info("refreshing source " + source.name);
 source.refresh();
 // We reset the last refreshed timestamp here even though the refresh
 // is asynchronous, so we don't yet know whether it has succeeded.
 // The upside of this approach is that we don't keep trying to refresh