changeset 318:0856399a6a9e

comment about two things that need fixing in SnowlFeed::onRefreshResult
author Myk Melez <myk@mozilla.org>
date Thu, 09 Oct 2008 17:30:24 -0700
parents 27a89f014e81
children a6cafdade667
files modules/feed.js
diffstat 1 files changed, 7 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/modules/feed.js	Thu Oct 09 15:42:00 2008 -0700
+++ b/modules/feed.js	Thu Oct 09 17:30:24 2008 -0700
@@ -231,12 +231,19 @@
   },
 
   onRefreshResult: function(aResult) {
+    // FIXME: Make this be "snowl:refresh:start" or move it into the subscribing
+    // caller so it makes sense that it's called "snowl:subscribe:get:start",
+    // since this method also gets called during periodically on feeds to which
+    // the user is already subscribed.
     Observers.notify(this, "snowl:subscribe:get:start", null);
 
     // Now that we know we successfully downloaded the feed and obtained
     // a result from it, update the "last refreshed" timestamp.
     this.lastRefreshed = new Date();
 
+    // FIXME: handle the case where this throws |aResult.doc is null|
+    // because the feed processor couldn't parse the feed file
+    // (f.e. because its content isn't a valid feed).
     let feed = aResult.doc.QueryInterface(Components.interfaces.nsIFeed);
 
     let currentMessageIDs = [];