Mercurial > snowl

changeset 304:8a10d1961e93

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
add a non-columnar mode to the river view, and let the user toggle columns on and off
author Myk Melez <myk@mozilla.org>
date Wed, 01 Oct 2008 18:57:46 -0700
parents 9125fd7d2952
children 71b4dece4931
files content/icons/application_view_columns.png content/river.css content/river.js content/river.xul content/riverContent.css locale/en-US/river.dtd
diffstat 6 files changed, 67 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
Binary file content/icons/application_view_columns.png has changed
--- a/content/river.css	Wed Oct 01 16:35:14 2008 -0700
+++ b/content/river.css	Wed Oct 01 18:57:46 2008 -0700
@@ -60,10 +60,17 @@
   display: block;
 }
 
+#columnResizeSplitter {
+  display: none;
+}
+
+#contentStack[columns] > #columnResizeSplitter {
+  display: -moz-box;
+}
+
 #contentBox {
   padding: 7px;
 
-  -moz-column-width: 400px;
   -moz-column-gap: 2em;
 
   -moz-user-focus: normal;
@@ -76,6 +83,8 @@
 
   /* This gets set programmatically on load, since setting it in CSS doesn't work. */
   height: 0;
+
+  -moz-box-flex: 1;
 }
 
 /* Make the title and source links look less like links to differentiate
--- a/content/river.js	Wed Oct 01 16:35:14 2008 -0700
+++ b/content/river.js	Wed Oct 01 18:57:46 2008 -0700
@@ -99,6 +99,13 @@
     return this._orderButton;
   },
 
+  get _columnsButton() {
+    let columnsButton = document.getElementById("columnsButton");
+    delete this._columnsButton;
+    this._columnsButton = columnsButton;
+    return this._columnsButton;
+  },
+
   get _filterTextbox() {
     delete this._filter;
     return this._filter = document.getElementById("filterTextbox");
@@ -136,11 +143,13 @@
   },
 
   set columnWidth(newVal) {
-    document.getElementById("contentBox").style.MozColumnWidth = newVal + "px";
+    this._updateContentRule(0, "#contentStack[columns] > #scrollBox > " +
+                               "#contentBox { -moz-column-width: " + newVal +
+                               "px }");
 
     // Set the maximum width for images in the content so they don't stick out
     // the side of the columns.
-    this._updateContentRule(0, "#contentBox img { max-width: " + newVal + "px }");
+    this._updateContentRule(1, "#contentBox img { max-width: " + newVal + "px }");
   },
 
   _updateContentRule: function(position, newValue) {
@@ -157,8 +166,8 @@
 
     // Set the maximum height for images and tables in the content so they
     // don't make the columns taller than the height of the content box.
-    this._updateContentRule(1, "#contentBox img { max-height: " + newVal + "px }");
-    this._updateContentRule(2, "#contentBox table { max-height: " + newVal + "px }");
+    this._updateContentRule(2, "#contentBox img { max-height: " + newVal + "px }");
+    this._updateContentRule(3, "#contentBox table { max-height: " + newVal + "px }");
   },
 
   _window: null,
@@ -238,6 +247,14 @@
       this._orderButton.image = "chrome://snowl/content/arrow-up.png";
     }
 
+    if ("columns" in this._params) {
+      this._columnsButton.checked = true;
+      // XXX This feels like the wrong place to do this, but I don't see
+      // a better place at the moment.  Yuck, the whole process by which
+      // the view gets built needs to get cleaned up and documented.
+      this._setColumns(this._columnsButton.checked);
+    }
+
     let selected = false;
     if ("collection" in this._params) {
       //dump("this._params.collection: " + this._params.collection + "; this._params.group: " + this._params.group + "\n");
@@ -314,6 +331,26 @@
     this._updateURI();
   },
 
+  onCommandColumnsButton: function() {
+    this._setColumns(this._columnsButton.checked);
+    this._updateURI();
+  },
+
+  _setColumns: function(columns) {
+    if (columns) {
+      document.getElementById("contentStack").setAttribute("columns", true);
+      // Enable the keys that map PageUp and PageDown to PageLeft and PageRight.
+      document.getElementById("pageLeftKey").removeAttribute("disabled");
+      document.getElementById("pageRightKey").removeAttribute("disabled");
+    }
+    else {
+      document.getElementById("contentStack").removeAttribute("columns");
+      document.getElementById("pageLeftKey").setAttribute("disabled", "true");
+      document.getElementById("pageRightKey").setAttribute("disabled", "true");
+    }
+    
+  },
+
   _updateURI: function() {
     let params = [];
 
@@ -323,6 +360,9 @@
     if (this._bodyButton.checked)
       params.push("body");
 
+    if (this._columnsButton.checked)
+      params.push("columns");
+
     if (this._collection.id)
       params.push("collection=" + this._collection.id);
     else if (this._collection.parent) {
--- a/content/river.xul	Wed Oct 01 16:35:14 2008 -0700
+++ b/content/river.xul	Wed Oct 01 18:57:46 2008 -0700
@@ -52,8 +52,8 @@
   <script type="application/javascript" src="chrome://snowl/content/river.js"/>
 
   <keyset>
-    <key keycode="VK_PAGE_UP" oncommand="SnowlMessageView.doPageMove(-1)"/>
-    <key keycode="VK_PAGE_DOWN" oncommand="SnowlMessageView.doPageMove(1)"/>
+    <key id="pageLeftKey" keycode="VK_PAGE_UP" oncommand="SnowlMessageView.doPageMove(-1)" disabled="true"/>
+    <key id="pageRightKey" keycode="VK_PAGE_DOWN" oncommand="SnowlMessageView.doPageMove(1)" disabled="true"/>
     <key keycode="VK_PAGE_UP" modifiers="shift" oncommand="SnowlMessageView.doColumnMove(-1)"/>
     <key keycode="VK_PAGE_DOWN" modifiers="shift" oncommand="SnowlMessageView.doColumnMove(1)"/>
     <key keycode="VK_HOME" oncommand="SnowlMessageView.onHome()"/>
@@ -82,13 +82,18 @@
                     oncommand="SnowlMessageView.onCommandOrderButton(event)"
                     tooltiptext="&orderButton.tooltip;"/>
 
+        <toolbarbutton id="columnsButton" type="checkbox"
+                    image="chrome://snowl/content/icons/application_view_columns.png"
+                    oncommand="SnowlMessageView.onCommandColumnsButton(event)"
+                    tooltiptext="&columnsButton.tooltip;"/>
+
         <spacer flex="1"/>
 
         <textbox id="filterTextbox" type="timed" timeout="200"
                      oncommand="SnowlMessageView.onFilter(event)"/>
       </toolbar>
     
-      <stack flex="1">
+      <stack id="contentStack" flex="1">
         <scrollbox id="scrollBox"
                    style="overflow: auto;"
                    onoverflow="SnowlMessageView.onFlowChange(event)"
--- a/content/riverContent.css	Wed Oct 01 16:35:14 2008 -0700
+++ b/content/riverContent.css	Wed Oct 01 18:57:46 2008 -0700
@@ -40,6 +40,10 @@
 
 /* rules that get updated programmatically */
 
+#contentStack[columns] > #scrollBox > #contentBox {
+  -moz-column-width: 400px;
+}
+
 /* Images should only be as wide as columns, which is 400px by default. */
 #contentBox img {
   max-width: 400px;
--- a/locale/en-US/river.dtd	Wed Oct 01 16:35:14 2008 -0700
+++ b/locale/en-US/river.dtd	Wed Oct 01 18:57:46 2008 -0700
@@ -2,3 +2,4 @@
 <!ENTITY currentButton.tooltip        "Only show current messages.">
 <!ENTITY bodyButton.tooltip           "Show message summaries/content.">
 <!ENTITY orderButton.tooltip          "Reverse the order of the messages.">
+<!ENTITY columnsButton.tooltip        "Show the messages in columns.">