changeset 281:92bff6641dcd

add a comment that we should fix knowledge of semantics at too low a level in the datastore module
author Myk Melez <myk@mozilla.org>
date Mon, 01 Sep 2008 19:00:44 -0700
parents 7c353a230c70
children 76ee747a1dba
files modules/datastore.js
diffstat 1 files changed, 2 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/modules/datastore.js	Mon Sep 01 19:00:11 2008 -0700
+++ b/modules/datastore.js	Mon Sep 01 19:00:44 2008 -0700
@@ -475,6 +475,8 @@
     this._insertMessageStatement.params.externalID = aExternalID;
     this._insertMessageStatement.params.subject = aSubject;
     this._insertMessageStatement.params.authorID = aAuthorID;
+    // FIXME: this method is too low-level to be in charge of massaging data;
+    // make its callers convert the date values to Julian Dates or null values.
     let timestamp = aTimestamp ? SnowlUtils.jsToJulianDate(aTimestamp) : null;
     this._insertMessageStatement.params.timestamp = timestamp;
     let received = aReceived ? SnowlUtils.jsToJulianDate(aReceived) : null;