Mercurial > spidermonkey-playground

diff wrapper.cpp @ 36:be05a91e7b0a

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fixed TODOs in wrapper.cpp.
author Atul Varma <varmaa@toolness.com>
date Mon, 22 Jun 2009 15:54:37 -0700
parents afca92a2e72e
children 36d57955327e
line wrap: on
line diff
--- a/wrapper.cpp	Mon Jun 22 15:40:46 2009 -0700
+++ b/wrapper.cpp	Mon Jun 22 15:54:37 2009 -0700
@@ -98,7 +98,7 @@
         return JS_FALSE;
       }
       *idp = JSVAL_ZERO;
-      // TODO: Root the enumeration iterator?
+      JS_AddRoot(cx, statep);
       return JS_TRUE;
     }
     // TODO: Default behavior?
@@ -118,7 +118,7 @@
         if (klass && strcmp(klass->name, "StopIteration") == 0) {
           JS_ClearPendingException(cx);
           *statep = JSVAL_NULL;
-          // TODO: Unroot the enumeration iterator?
+          JS_RemoveRoot(cx, statep);
           return JS_TRUE;
         }
       }
@@ -128,7 +128,7 @@
       return JS_FALSE;
     return JS_TRUE;
   case JSENUMERATE_DESTROY:
-    // TODO: Unroot the enumeration iterator?
+    JS_RemoveRoot(cx, statep);
     return JS_TRUE;
   }
 }