Mercurial > personas_backend

changeset 38:ccdb8d6379d3

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Moved a TODO from views to models.
author Atul Varma <varmaa@toolness.com>
date Mon, 03 Mar 2008 17:13:13 -0600
parents ad477306dd51
children bd1cdb15ef85
files PersonasBackend/personas/models.py PersonasBackend/personas/views.py
diffstat 2 files changed, 8 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/PersonasBackend/personas/models.py	Thu Feb 28 17:14:25 2008 -0800
+++ b/PersonasBackend/personas/models.py	Mon Mar 03 17:13:13 2008 -0600
@@ -242,6 +242,14 @@
         if self.id == None:
             self.revision = 0
         else:
+            # TODO: See who made the update; depending on how much we
+            # trust them, this may mean:
+            #
+            #   * rejecting the change, 
+            #   * accepting the changes but marking the persona's
+            #     status as "needs review",
+            #   * accepting the changes.
+
             self.__makeNewRevision()
 
         super(Persona, self).save()
--- a/PersonasBackend/personas/views.py	Thu Feb 28 17:14:25 2008 -0800
+++ b/PersonasBackend/personas/views.py	Mon Mar 03 17:13:13 2008 -0600
@@ -23,10 +23,6 @@
         form = forms.PersonaForm( formData )
     persona = form.save( commit=False )
     persona.updater = user
-    # TODO: Based on the permissions of the user, the status
-    # should be set to "needs review" or "published", depending on
-    # how much we trust them.
-    persona.status = "needs_review"
     # TODO: Add validation to ensure that all required fields
     # are properly filled out.
     persona.save()