Mercurial > snowl

changeset 264:e294475faeb2

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
properly format dates in the future
author Myk Melez <myk@mozilla.org>
date Mon, 25 Aug 2008 18:49:46 -0700
parents 848e068587c5
children 196c26539e2c
files modules/utils.js
diffstat 1 files changed, 43 insertions(+), 38 deletions(-) [+]
line wrap: on
line diff
--- a/modules/utils.js	Mon Aug 25 18:20:52 2008 -0700
+++ b/modules/utils.js	Mon Aug 25 18:49:46 2008 -0700
@@ -72,56 +72,61 @@
    * @returns a human-readable string representing the date
    */
   _formatDate: function(date) {
-    let result;
-
+    let day = new Date(date.getFullYear(), date.getMonth(), date.getDate());
     let now = new Date();
+    let today = new Date(now.getFullYear(), now.getMonth(), now.getDate());
 
-    let today = new Date(now.getFullYear(), now.getMonth, now.getDate());
-
-    let yesterday = new Date(now - 24 * 60 * 60 * 1000);
+    let yesterday = new Date(now - 1000 * 60 * 60 * 24);
     yesterday = new Date(yesterday.getFullYear(),
                          yesterday.getMonth(),
                          yesterday.getDate());
 
-    let sixDaysAgo = new Date(now - 6 * 24 * 60 * 60 * 1000);
+    let sixDaysAgo = new Date(now - 1000 * 60 * 60 * 24 * 6);
     sixDaysAgo = new Date(sixDaysAgo.getFullYear(),
                           sixDaysAgo.getMonth(),
                           sixDaysAgo.getDate());
 
-    if (date.toLocaleDateString() == now.toLocaleDateString())
-      result = this._dfSvc.FormatTime("",
-                                      this._dfSvc.timeFormatNoSeconds,
+    // If it's in the future or more than six days in the past, format it
+    // as a full date/time string, i.e.: 2008-05-13 15:37:42.
+    if (day > today || day < sixDaysAgo)
+      return this._dfSvc.FormatDateTime("",
+                                        Ci.nsIScriptableDateFormat.dateFormatShort,
+                                        Ci.nsIScriptableDateFormat.timeFormatNoSeconds,
+                                        date.getFullYear(),
+                                        date.getMonth() + 1,
+                                        date.getDate(),
+                                        date.getHours(),
+                                        date.getMinutes(),
+                                        date.getSeconds());
+
+    // If it's today, only show the time.
+    if (day.getTime() == today.getTime())
+      return this._dfSvc.FormatTime("",
+                                    Ci.nsIScriptableDateFormat.timeFormatNoSeconds,
+                                    date.getHours(),
+                                    date.getMinutes(),
+                                    null);
+
+    // If it's yesterday, show "Yesterday" plus the time.
+    // FIXME: make this localizable.
+    if (day.getTime() == yesterday.getTime())
+      return "Yesterday " +
+             this._dfSvc.FormatTime("",
+                                    Ci.nsIScriptableDateFormat.timeFormatNoSeconds,
+                                    date.getHours(),
+                                    date.getMinutes(),
+                                    null);
+
+    // It's two to six days ago, so show the day of the week plus the time.
+    return this._dfSvc.FormatDateTime("",
+                                      Ci.nsIScriptableDateFormat.dateFormatWeekday, 
+                                      Ci.nsIScriptableDateFormat.timeFormatNoSeconds,
+                                      date.getFullYear(),
+                                      date.getMonth() + 1,
+                                      date.getDate(),
                                       date.getHours(),
                                       date.getMinutes(),
-                                      null);
-    else if (date > yesterday)
-      result = "Yesterday " + this._dfSvc.FormatTime("",
-                                                     this._dfSvc.timeFormatNoSeconds,
-                                                     date.getHours(),
-                                                     date.getMinutes(),
-                                                     null);
-    else if (date > sixDaysAgo)
-      result = this._dfSvc.FormatDateTime("",
-                                          this._dfSvc.dateFormatWeekday, 
-                                          this._dfSvc.timeFormatNoSeconds,
-                                          date.getFullYear(),
-                                          date.getMonth() + 1,
-                                          date.getDate(),
-                                          date.getHours(),
-                                          date.getMinutes(),
-                                          date.getSeconds());
-    else
-      result = this._dfSvc.FormatDateTime("",
-                                          this._dfSvc.dateFormatShort, 
-                                          this._dfSvc.timeFormatNoSeconds,
-                                          date.getFullYear(),
-                                          date.getMonth() + 1,
-                                          date.getDate(),
-                                          date.getHours(),
-                                          date.getMinutes(),
-                                          date.getSeconds());
-
-    return result;
+                                      date.getSeconds());
   }
 
 };