Mercurial > universal-identity-relyer

changeset 9:42fe50c20cc8

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
renamed success_delegate -> onsuccess
author Atul Varma <avarma@mozilla.com>
date Sat, 12 Jun 2010 20:08:05 -0700
parents 51dfea268026
children 1686a3266557
files oauth_experiment.py test_twitter_client.py twitter_client.py
diffstat 3 files changed, 10 insertions(+), 11 deletions(-) [+]
line wrap: on
line diff
--- a/oauth_experiment.py	Sat Jun 12 20:06:52 2010 -0700
+++ b/oauth_experiment.py	Sat Jun 12 20:08:05 2010 -0700
@@ -36,5 +36,5 @@
     consumer=consumer,
     oauth=oauth,
     request_tokens=Storage(),
-    success_delegate=success_app
+    onsuccess=success_app
     )
--- a/test_twitter_client.py	Sat Jun 12 20:06:52 2010 -0700
+++ b/test_twitter_client.py	Sat Jun 12 20:08:05 2010 -0700
@@ -11,10 +11,10 @@
         request_tokens = {}
     consumer = 'mock consumer'
     oauth = Mock('oauth')
-    success_delegate = Mock('success_delegate')
+    onsuccess = Mock('onsuccess')
     toc = TwitterOauthClientApp(consumer, oauth,
-                                request_tokens, success_delegate)
-    return (consumer, oauth, success_delegate, toc)
+                                request_tokens, onsuccess)
+    return (consumer, oauth, onsuccess, toc)
 
 def test_404():
     """
@@ -55,7 +55,7 @@
 def test_callback(self):
     """
     >>> storage = {'token': {'oauth_token': 'token', 'oauth_token_secret': 'secret'}}
-    >>> consumer, oauth, success_delegate, toc = app(storage)
+    >>> consumer, oauth, onsuccess, toc = app(storage)
     >>> client = Mock('client')
     >>> client.request.mock_returns = (
     ...   {'status': '200'},
@@ -71,13 +71,13 @@
     ...   SERVER_NAME='foo.com', SERVER_PORT='80'
     ... )
     >>> environ['wsgi.url_scheme'] = 'http'
-    >>> success_delegate.mock_returns = ['success']
+    >>> onsuccess.mock_returns = ['success']
     >>> toc(environ, Mock('start_response'))
     Called oauth.Token('token', 'secret')
     Called token.set_verifier('verifier')
     Called oauth.Client('mock consumer', <Mock token>)
     Called client.request('https://api.twitter.com/oauth/access_token', 'POST')
-    Called success_delegate(
+    Called onsuccess(
         {'SERVER_NAME': 'foo.com', 'wsgi.url_scheme': 'http', 'PATH_INFO': '/callback', 'SERVER_PORT': '80', 'oauth.access_token': {'oauth_token_secret': 'secret', 'user_id': 'userid', 'oauth_token': 'token', 'screen_name': 'bob'}, 'QUERY_STRING': 'oauth_token=token&oauth_verifier=verifier'},
         <Mock start_response>)
     ['success']
--- a/twitter_client.py	Sat Jun 12 20:06:52 2010 -0700
+++ b/twitter_client.py	Sat Jun 12 20:08:05 2010 -0700
@@ -8,11 +8,10 @@
     access_token_url = 'https://api.twitter.com/oauth/access_token'
     authorize_url = 'https://api.twitter.com/oauth/authorize'
 
-    def __init__(self, consumer, oauth, request_tokens,
-                 success_delegate):
+    def __init__(self, consumer, oauth, request_tokens, onsuccess):
         self.oauth = oauth
         self.consumer = consumer
-        self.success_delegate = success_delegate
+        self.onsuccess = onsuccess
         self.request_tokens = request_tokens
 
     def __call__(self, environ, start_response):
@@ -68,7 +67,7 @@
                 raise Exception("Invalid response %s." % resp['status'])
             access_token = dict(urlparse.parse_qsl(content))
             environ['oauth.access_token'] = access_token
-            return self.success_delegate(environ, start_response)
+            return self.onsuccess(environ, start_response)
 
         start_response('404 Not Found',
                        [('Content-Type', 'text/plain')])